Feat/heartbeat count#769
Merged
davidporter-id-au merged 2 commits intotemporalio:masterfrom Apr 22, 2026
Merged
Conversation
fretz12
approved these changes
Apr 22, 2026
Sushisource
approved these changes
Apr 22, 2026
spkane31
pushed a commit
that referenced
this pull request
Apr 24, 2026
<!-- Describe what has changed in this PR --> **What changed?** This adds a field for counting the total number of heartbeats given to an activity, as received by the server (as an aside, this may be less than the client activity.RecordHeartbeat() calls due to the client's throttling of this call. For this change, I'm just commandeering the work already done by @fretz12. <!-- Tell your future self why have you made these changes --> **Why?** This is to provide this information about the total number of heartbeats in the DescribeActivity API call / CLi invocation. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Should be backwards compatible. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** Should be backwards compatible. Co-authored-by: Fred Tzeng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This adds a field for counting the total number of heartbeats given to an activity, as received by the server (as an aside, this may be less than the client activity.RecordHeartbeat() calls due to the client's throttling of this call.
For this change, I'm just commandeering the work already done by @fretz12.
Why?
This is to provide this information about the total number of heartbeats in the DescribeActivity API call / CLi invocation.
Breaking changes
Should be backwards compatible.
Server PR
Should be backwards compatible.